[PATCH] Add MCSymbolizer for disassembled instruction symbolization/annotation.
Quentin Colombet
qcolombet at apple.com
Thu May 23 16:38:53 PDT 2013
Allmost there!
See the inlined comment.
Thanks,
Quentin
================
Comment at: lib/Target/ARM/Disassembler/ARMDisassembler.cpp:507
@@ +506,3 @@
+ // FIXME: Does it make sense for value to be negative?
+ return Dis->tryAddingSymbolicOperand(MI, (uint32_t)Value, Address, isBranch,
+ /* Offset */ 0, InstSize);
----------------
Why do you cast Value into a uint32_t here?
The API supports that and that would eliminate the FIXME.
http://llvm-reviews.chandlerc.com/D801
BRANCH
mcsymzer
ARCANIST PROJECT
llvm
More information about the llvm-commits
mailing list