[llvm] r182499 - This is an update to a previous commit (r181216).

[Rafael Espíndola]

On 22 May 2013 16:29, Jean-Luc Duprat <jduprat at apple.com> wrote:
> I agree that the select is a more natural canonical form, and I was initially convinced that this was the way to go.
> But none of the platforms with an FMA actually benefit from seeing this in the select form; in general, floating-point multiplies are likely better optimized than floating point selects anyways.
>
> It seems that we'd have to fix each and every platform to undo this particular instcombine, so it is probably better to just do it as a target specific optimization where it truly is the better choice.  This just seems to be the better compromise here.

OK, so instcombine should do the opposite transformation: convert a
select to a uitofp and a multiplication.

> JL
>

Cheers,
Rafael