[PATCH] [lld][LayoutPass] Consolidate debug flags, removing "layout" flag.

Rui Ueyama ruiu at google.com
Wed May 22 15:28:53 PDT 2013


Hi shankarke,

DEBUG_TYPE is already defined at the beginning of this file. We don't
want to have two different debug flags for a single pass.

http://llvm-reviews.chandlerc.com/D845

Files:
  lib/Passes/LayoutPass.cpp

Index: lib/Passes/LayoutPass.cpp
===================================================================
--- lib/Passes/LayoutPass.cpp
+++ lib/Passes/LayoutPass.cpp
@@ -11,9 +11,7 @@
 #define DEBUG_TYPE "LayoutPass"
 
 #include "lld/Passes/LayoutPass.h"
-
 #include "lld/Core/Instrumentation.h"
-
 #include "llvm/Support/Debug.h"
 
 using namespace lld;
@@ -413,7 +411,7 @@
   // Build override maps
   buildOrdinalOverrideMap(atomRange);
 
-  DEBUG_WITH_TYPE("layout", {
+  DEBUG({
     llvm::dbgs() << "unsorted atoms:\n";
     for (const DefinedAtom *atom : atomRange) {
       llvm::dbgs() << "  file=" << atom->file().path()
@@ -428,7 +426,7 @@
   // sort the atoms
   std::sort(atomRange.begin(), atomRange.end(), _compareAtoms);
 
-  DEBUG_WITH_TYPE("layout", {
+  DEBUG({
     llvm::dbgs() << "sorted atoms:\n";
     for (const DefinedAtom *atom : atomRange) {
       llvm::dbgs() << "  file=" << atom->file().path()
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D845.1.patch
Type: text/x-patch
Size: 921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130522/af589911/attachment.bin>


More information about the llvm-commits mailing list