[lld] r182494 - [lld][LayoutPass] An earlier commit moved the functionality so that Atoms would

[Shankar Easwaran]

On 5/22/2013 1:29 PM, Rui Ueyama wrote:
> LGTM. A few minor comments.
>
> +  // Sort by section position preference.
>> +  DefinedAtom::SectionPosition leftPos = left->sectionPosition();
>> +  DefinedAtom::SectionPosition rightPos = right->sectionPosition();
>> +
>> +  DEBUG(llvm::dbgs() << "Sorting by sectionPos"
>> +                     << "(" << leftPos << "," << rightPos << ")\n");
>>
> I'd move this part into the following "if (leftSpecialPos ||
> rightSpecialPos)" block.
>
This is just used to trace the LayoutPass, I wouldnt want to put it 
under the if condition. See other DEBUG statements too, they are outside.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation