[llvm] r182122 - R600: Factorize Fetch size limit inside AMDGPUSubTarget

Renato Golin renato.golin at linaro.org
Wed May 22 07:06:15 PDT 2013


On 17 May 2013 18:49, Matt Beaumont-Gay <matthewbg at google.com> wrote:

> > +  TexVTXClauseSize = (Device->getGeneration() >=
> AMDGPUDeviceInfo::HD4XXX)?16:8;
>
> Style nit: Spaces around '?' and ':', please.
>

I also get a warning on that line:

lib/Target/R600/AMDGPUSubtarget.cpp:40:68: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130522/31861a49/attachment.html>


More information about the llvm-commits mailing list