[llvm] r182233 - Partially revert change in r181200 that tried to simplify JIT unit test #ifdefs.

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Tue May 21 03:34:07 PDT 2013


Bob Wilson <bob.wilson at apple.com> wrote on 20.05.2013 18:35:03:

> > The attached patch reverts your 182233 revision and instead pulls the
> > two definitions up.  This still allows me to bootstrap with no
> > warnings on SystemZ.  Can you confirm that this still solves your
> > problem?
>
> Yes, I think that ought to work.  That is exactly what I was
> suggesting about rearranging the code.  I haven't actually tried to
> reproduce the exact test that our buildbot is running, but let's go
> ahead with your patch and see what happens.

OK, checked in as r182367.

> BTW, the JITTests.def file is converted by the Makefile in that
> directory to a JITTests.exports file that gets used on other
> platforms besides Windows.  We very recently added support for -
> export-dynamic to Apple's linker, but without that, an LTO build of
> LLVM requires those exports for the unit tests.  When newer versions
> of the linker are more widespread, I will try to remove the exports
> file for non-Windows platforms, since the GNU linker has supported -
> export-dynamic for a long time.

I see, thanks for the info!

Bye,
Ulrich




More information about the llvm-commits mailing list