[llvm] r182348 - Add an md5 library derived from a public domain implementation for dwarf4

[Eric Christopher]

On Mon, May 20, 2013 at 7:30 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> On Mon, May 20, 2013 at 6:28 PM, Eric Christopher <echristo at gmail.com>
> wrote:
>>
>> Author: echristo
>> Date: Mon May 20 20:28:35 2013
>> New Revision: 182348
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=182348&view=rev
>> Log:
>> Add an md5 library derived from a public domain implementation for dwarf4
>> type signature computation.
>>
>> Added:
>>     llvm/trunk/include/llvm/Support/MD5.h
>>     llvm/trunk/lib/Support/MD5.cpp
>
>
> Tests would be nice!
>

Incoming :)

>> +  /// \brief Updates the hash for arguments provided.
>> +  void Update(void *data, unsigned long size);
>
>
> ArrayRef? Also 'update', 'Data', 'Size'.

OK. Will do.

>
>>
>> +
>> +  /// \brief Finishes off the hash and puts the result in result.
>> +  void Final(unsigned char *result);
>
>
> unsigned char (&result)[16] here; a typedef for "unsigned char [16]" might
> be useful too.
>

*nod*

Thanks!

-eric