[PATCH] [lld][ELF] Add linker script ENTRY command
Shankar Kalpathi Easwaran
shankarke at gmail.com
Mon May 20 19:30:17 PDT 2013
================
Comment at: lib/Driver/Driver.cpp:58
@@ +57,3 @@
+ // Give target a chance to fix missing linker options.
+ targetInfo.maybeSetDefaultOptions();
+
----------------
Michael Spencer wrote:
> Shankar Kalpathi Easwaran wrote:
> > This should be probably converted to ELFTargetInfo and the values set in the ELFTargetInfo class.
> This is non-elf-specific code.
Sorry for not being clear. What I was trying to say here, is this piece of code should live in GnuLdDriver and ELFTargetInfo should have the setDefault functions, leaving the TargetOptions interface exactly the same.
http://llvm-reviews.chandlerc.com/D833
BRANCH
linker-script-entry
ARCANIST PROJECT
lld
More information about the llvm-commits
mailing list