[compiler-rt] r182177 - Fix the UBSan CMake build broken in r182118

[Peter Collingbourne]

On Fri, May 17, 2013 at 11:57:24PM -0000, David Blaikie wrote:
> Author: dblaikie
> Date: Fri May 17 18:57:24 2013
> New Revision: 182177
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=182177&view=rev
> Log:
> Fix the UBSan CMake build broken in r182118
> 
> Modified:
>     compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
> 
> Modified: compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt?rev=182177&r1=182176&r2=182177&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt (original)
> +++ compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt Fri May 17 18:57:24 2013
> @@ -83,7 +83,9 @@ else()
>      add_compiler_rt_object_library(RTSanitizerCommonLibc ${arch}
>        SOURCES ${SANITIZER_LIBCDEP_SOURCES} CFLAGS ${SANITIZER_CFLAGS})
>      add_compiler_rt_static_runtime(clang_rt.san-${arch} ${arch}
> -      SOURCES ${SANITIZER_SOURCES} CFLAGS ${SANITIZER_CFLAGS})
> +      SOURCES ${SANITIZER_SOURCES}
> +      $<TARGET_OBJECTS:RTSanitizerCommonLibc.${arch}> CFLAGS
> +      ${SANITIZER_CFLAGS})

So it looks like we're building most of sanitizer_common's
objects twice here.  Is there any reason why we shouldn't use
RTSanitizerCommon's objects when building clang_rt.san?

Thanks,
-- 
Peter