[lld] r182076 - [lld][ELF][X86_64] Reorganize X86_64 Target specific code

[Sean Silva]

On Fri, May 17, 2013 at 3:10 PM, Shankar Easwaran
<shankare at codeaurora.org>wrote:

> On 5/17/2013 3:42 PM, Sean Silva wrote:
>
>> Unrelated to the patch, but can these be `static`?:
>>
>> +const uint8_t X86_64PLTAtom::_**defaultContent[16] = {
>> +  0xff, 0x25, 0x00, 0x00, 0x00, 0x00, // jmpq *gotatom(%rip)
>> +  0x68, 0x00, 0x00, 0x00, 0x00,       // pushq reloc-index
>> +  0xe9, 0x00, 0x00, 0x00, 0x00        // jmpq plt[-1]
>> +};
>>
>> -- Sean Silva
>>
>>  Thanks for your reply, Sean.
>
> These cannot be static, as these are entries for each PLT entry. Each PLT
> entry may have a different relocation index, thats pointing to the
> .rela.dyn entry.
>

Sorry, I think I miscommunicated. What I meant is whether these small
_defaultContent arrays can be put in an anonymous namespace or otherwise
internalized so that they do not appear as symbols in the final lld binary.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130517/4d4f1d30/attachment.html>