[PATCH] [nolibc] Add RTSanitizerCommonLibc, the libc-dependent subset of sanitizer_common.

Kostya Serebryany kcc at google.com
Fri May 17 01:52:49 PDT 2013


  Looks good (with one style nit), but the changes that move large parts of code between files are hard to review.

  Please commit this change as a series of smaller CLs, where every CL either changes code or moves code, but not both.
  We will do additional post-commit review.
  Please also watch the bots and lint


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer.h:69
@@ -68,2 +68,3 @@
 // This function should NOT be called from two threads simultaneously.
-uptr SymbolizeCode(uptr address, AddressInfo *frames, uptr max_frames);
+uptr SymbolizeCode(uptr address, AddressInfo* frames, uptr max_frames)
+    SANITIZER_WEAK_ATTRIBUTE;
----------------
the code uses 'Type *var', not "Type* var"


http://llvm-reviews.chandlerc.com/D757

BRANCH
  nolibc3

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list