[PATCH] [nolibc] Add RTSanitizerCommonLibc, the libc-dependent subset of sanitizer_common.

Peter Collingbourne peter at pcc.me.uk
Thu May 16 08:36:18 PDT 2013


  > Maybe we could create a few new files, like sanitizer_xxx_libcdep.cc, which and only which are allowed to depend on libc?  Then your target will simply omit those files.

  That sounds like a good idea; done.  Some of the libc-dependent implementations will probably have to change anyway, so there shouldn't be as much (unnecessary) churn as I originally thought.


================
Comment at: lib/sanitizer_common/sanitizer_allocator.cc:33
@@ -32,1 +32,3 @@
 
+#if !SANITIZER_NOLIBC
+
----------------
Kostya Serebryany wrote:
> Please give us a chance to get rid of this. The change is under review now. 
> Unfortunately it may still take some time since samsonov@ is on vacation. :( 
OK, the new patch keeps these functions in.  With samsonov's patch applied on top of mine, RTSanitizerCommon becomes libc-free.

================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:627
@@ -617,3 +626,3 @@
 
-#ifndef SANITIZER_GO
+#ifndef SANITIZER_NOLIBC
 //------------------------- SlowUnwindStack -----------------------------------
----------------
Kostya Serebryany wrote:
> Hm? replaced GO with NOLIBC ? 
I think this was a mistake I made while resolving a merge conflict.  Fixed in the new patch.


http://llvm-reviews.chandlerc.com/D757



More information about the llvm-commits mailing list