[PATCH] [LSan] Common leak checking module.
Alexander Potapenko
glider at google.com
Thu May 16 07:13:22 PDT 2013
================
Comment at: lib/lsan/lsan_common.h:134
@@ +133,3 @@
+ void operator()(void *p) const;
+
+ private:
----------------
Nit: spare newline
================
Comment at: lib/lsan/lsan_common.h:180
@@ +179,3 @@
+class LsanMetadata {
+ void *metadata_;
+ public:
----------------
Please put this into a private section.
================
Comment at: lib/lsan/lsan_common.h:93
@@ +92,3 @@
+ bool IsEmpty() { return leaks_.size() == 0; }
+
+ private:
----------------
Nit: spare newline
http://llvm-reviews.chandlerc.com/D787
More information about the llvm-commits
mailing list