[llvm] r181759 - Fix typo.

Reed Kotler rkotler at mips.com
Tue May 14 14:04:52 PDT 2013


On 05/14/2013 06:31 AM, Rafael EspĂ­ndola wrote:
> can you test this?
>
I tested it .

It worked before but for a lucky reason.
It just caused their build to break because of the clang warning.

I'm creating a new build area which builds with a clang compiler and 
with warnings as errors enabled ( which I thought I already had in my 
checkin area but I must have changed something ).

This code was already not called if pic relocation is present.
This check was redundant but always resulted in false which is the 
correct answer (this function is not called if pic is on).

> On 14 May 2013 02:00, Reed Kotler <rkotler-8NJIiSa5LzA at public.gmane.org> wrote:
>> Author: rkotler
>> Date: Tue May 14 01:00:01 2013
>> New Revision: 181759
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=181759&view=rev
>> Log:
>> Fix typo.
>>
>>
>> Modified:
>>      llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp
>>
>> Modified: llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp?rev=181759&r1=181758&r2=181759&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp (original)
>> +++ llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp Tue May 14 01:00:01 2013
>> @@ -241,7 +241,7 @@ static void swapFPIntParams
>>   static void assureFPCallStub(Function &F, Module *M,
>>                                const MipsSubtarget &Subtarget){
>>     // for now we only need them for static relocation
>> -  if (!Subtarget.getRelocationModel() == Reloc::PIC_)
>> +  if (Subtarget.getRelocationModel() == Reloc::PIC_)
>>       return;
>>     LLVMContext &Context = M->getContext();
>>     bool LE = Subtarget.isLittle();
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits-Tmj1lob9twqVc3sceRu5cw at public.gmane.org
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list