[PATCH] fix for wrong MMX packed sub definitions in X86InstrMMX.td.

Eric Christopher echristo at gmail.com
Tue May 14 10:53:37 PDT 2013


Applied here:

        A       test/CodeGen/X86/x86-64-psub.ll
        M       lib/Target/X86/X86InstrMMX.td
Committed r181809

-eric

On Tue, May 14, 2013 at 5:43 AM,  <Andrea_DiBiagio at sn.scee.net> wrote:
> Hello,
>
> I'd like to contribute a fix for wrong definitions of MMX packed sub
> instructions in X86InstrMMX.td.
>
> All the tablegen definitions of MMX packed sub instructions were wrongly
> marked
> as commutative. Because of this, the "Two-Address instruction pass"
> wrongly
> thought it was always safe to interchange the operands of psub
> instructions.
>
> The test case in the attached patch verifies that the Two-Address
> instruction
> pass never interchanges mmx packed sub instructions.
>
> Thanks,
> Andrea Di Biagio
> SN Systems - Sony Computer Entertainment Group
>
>
>
> **********************************************************************
> This email and any files transmitted with it are confidential and intended
> solely for the use of the individual or entity to whom they are addressed.
> If you have received this email in error please notify postmaster at scee.net
> This footnote also confirms that this email message has been checked for
> all known viruses.
> Sony Computer Entertainment Europe Limited
> Registered Office: 10 Great Marlborough Street, London W1F 7LP, United
> Kingdom
> Registered in England: 3277793
> **********************************************************************
>
> P Please consider the environment before printing this e-mail
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list