[PATCH] [sanitizer] LibraryNameIs in sanitizer_common
Kostya Serebryany
kcc at google.com
Tue May 14 05:46:55 PDT 2013
================
Comment at: lib/sanitizer_common/sanitizer_common.h:383
@@ +382,3 @@
+// information).
+bool LibraryNameIs(const char *full_name, const char *base_name);
+
----------------
this looks like a very linux-specific thing.
Why not sanitizer_common/sanitizer_linux.h ?
================
Comment at: lib/sanitizer_common/tests/sanitizer_common_test.cc:160
@@ -159,1 +159,3 @@
+#ifdef __linux__
+TEST(SanitizerCommon, LibraryNameIs) {
----------------
please use SANITIZER_LINUX or move to sanitizer_common/tests/sanitizer_linux_test.cc
http://llvm-reviews.chandlerc.com/D791
More information about the llvm-commits
mailing list