[PATCH][RFC] Add 'CHECK-<N>' directive in FileCheck

Richard Smith richard at metafoo.co.uk
Mon May 13 19:15:50 PDT 2013


If we keep this feature, please find some other syntax for it.

   grep 'CHECK-[0-9]' tools/clang/test

has *many* hits which would be broken by this.

On Mon, May 13, 2013 at 4:11 PM, Chandler Carruth <chandlerc at google.com>wrote:

> On Tue, May 14, 2013 at 1:07 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:
>
>> I think we should leave ‘grep’ in those tests until somebody properly
>> fixes them. I don’t think there is any benefit to mechanically changing
>> them to use FileCheck instead.
>>
>
> Not really advocating strongly for this feature, but it does have some
> value: it removes our test suite's reliance on the 'grep' tool on the host
> system, oddities of the syntax it uses, etc etc... Not sure its enough to
> justify the effort, but it is something.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130513/2e57494f/attachment.html>


More information about the llvm-commits mailing list