[PATCH] Tests and interface for LeakSanitizer.
Kostya Serebryany
kcc at google.com
Mon May 13 07:39:28 PDT 2013
LGTM with a style nit
================
Comment at: lib/lsan/tests/lsan_test.cc:215
@@ +214,3 @@
+ // Take p's address to ensure it's not optimized into a register.
+ void * volatile *pp = &p;
+ arg->hidden_p = HIDE(*pp);
----------------
our code uses 'void *foo', not "void * foo" and not "void* foo". Check other places.
Don't forget about lint too.
http://llvm-reviews.chandlerc.com/D677
BRANCH
lsan_interface_and_tests
ARCANIST PROJECT
compiler-rt
More information about the llvm-commits
mailing list