[llvm] r181632 - PR14492: Debug Info: Support for values of non-integer non-type template parameters.

[David Blaikie]

On Sat, May 11, 2013 at 3:07 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> On Sat, May 11, 2013 at 12:52 AM, David Blaikie <dblaikie at gmail.com> wrote:
>> Author: dblaikie
>> Date: Fri May 10 16:52:07 2013
>> New Revision: 181632
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=181632&view=rev
>> Log:
>> PR14492: Debug Info: Support for values of non-integer non-type template parameters.
>>
>> This is only tested for global variables at the moment (& includes tests
>> for the unnamed parameter case, since apparently this entire function
>> was completely untested previously)
>>
>> Added:
>>     llvm/trunk/test/DebugInfo/template.ll
>> Modified:
>>     llvm/trunk/include/llvm/DIBuilder.h
>>     llvm/trunk/include/llvm/DebugInfo.h
>>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
>>     llvm/trunk/lib/IR/DIBuilder.cpp
>>     llvm/trunk/lib/IR/DebugInfo.cpp
>>
>> Modified: llvm/trunk/include/llvm/DIBuilder.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DIBuilder.h?rev=181632&r1=181631&r2=181632&view=diff
>> ==============================================================================
>> --- llvm/trunk/include/llvm/DIBuilder.h (original)
>> +++ llvm/trunk/include/llvm/DIBuilder.h Fri May 10 16:52:07 2013
>> @@ -332,10 +332,9 @@ namespace llvm {
>>      /// @param LineNo       Line number.
>>      /// @param ColumnNo     Column Number.
>>      DITemplateValueParameter
>> -    createTemplateValueParameter(DIDescriptor Scope, StringRef Name, DIType Ty,
>> -                                 uint64_t Value,
>> -                                 MDNode *File = 0, unsigned LineNo = 0,
>> -                                 unsigned ColumnNo = 0);
>> +    createTemplateValueParameter(DIDescriptor Scope, StringRef Name,
>> +                                 DIType Ty, Value *Val, MDNode *File = 0,
>> +                                 unsigned LineNo = 0, unsigned ColumnNo = 0);
>
> -Wdocumentation complains:
>
> llvm/include/llvm/DIBuilder.h:330:16: warning: parameter 'Value' not
> found in the function declaration [-Wdocumentation]

Thanks - fixed (I assume) in r181664. Should we have this warning
on-by-default for the LLVM build (when building with a supporting
Clang)?