[PATCH] ARM unwind directive parser, assembler, and testcases.
Rafael Espíndola
rafael.espindola at gmail.com
Thu May 9 12:39:14 PDT 2013
> + return Error(Parser.getTok().getLoc(), "'#' expected");
> + }
> ----------------
> Rafael Ávila de Espíndola wrote:
>> '#' or '$'?
> IMHO, it will be better to use "'#' expect" in this patch. Some existing code is using this diagnostic message as well (such as parsePKHImm(), parseShifterImm(), parseRotImm(), and etc.) Besides, it seems that the dollar sign was added for backward compatibility with legacy code. Maybe it will be better to suggest the programmer to use the new prefix for constant literals.
OK.
Cheers,
Rafael
More information about the llvm-commits
mailing list