[PATCH] [nolibc] Change internal syscall API to remove reliance on libc's errno.
Peter Collingbourne
peter at pcc.me.uk
Wed May 8 04:23:48 PDT 2013
================
Comment at: lib/sanitizer_common/sanitizer_syscall_linux_x86_64.inc:1
@@ +1,2 @@
+//===-- sanitizer_syscall_linux_x86_64.inc ----------------------*- C++ -*-===//
+//
----------------
Kostya Serebryany wrote:
> Why not a regular .h file with include guards?
Because this file provides a definition for an external function (namely internal_iserror), I think it's better to have a fragment rather than a "true" header file.
(We could split this further into sanitizer_syscall_* and sanitizer_iserror_* but I don't think it's worth it.)
http://llvm-reviews.chandlerc.com/D756
More information about the llvm-commits
mailing list