[PATCH] [PowerPC, Darwin] fix for PR15821

David Fang fang at csl.cornell.edu
Tue May 7 19:29:24 PDT 2013


Hi Bill,
 	Can you re-try with the following options:

; RUN: llc -O0 -mcpu=g4 -mtriple=powerpc-apple-darwin8 < %s | FileCheck 
-check-prefix=DARWIN32 %s
; RUN: llc -O0 -mcpu=ppc970 -mtriple=powerpc64-apple-darwin8 < %s | 
FileCheck -check-prefix=DARWIN64 %s

See if that matches my test case expected output?

Fang

> On Wed, 2013-05-01 at 16:25 -0500, Bill Schmidt wrote:
>> David, the patch looks generally good.  I'll remove the FIXME since it's
>> now fixed.  Rather than cloning anon-aggr.ll, I'll just add the new
>> variants to that test case as well.  I probably won't get around to
>> committing it until tomorrow or the next day.
>
> Hi David,
>
> With the test case as written, I don't see the same code generation that
> you do.  I think we need to have a -mcpu=<machine> parameter in the RUN
> command to make sure we get universal code gen no matter which host
> machine is building the test.  What cpu are you using to get the code
> gen being tested for?
>
> (If you're unsure, run llc from the command line and look for
> the .machine directive in the generated assembly file.)
>
> Thanks,
> Bill
>
>>
>> Thanks,
>> Bill
>>
>> On Wed, 2013-05-01 at 17:08 -0400, David Fang wrote:
>>> Hi,
>>>
>>> Attached is a patch for PR 15821, which fixes PowerPC CodeGen on Darwin.
>>> It re-applies the same patch from PR 14779, and adds a test for darwin8,
>>> targeting ppc32 and ppc64.
>>>
>>> http://llvm.org/bugs/show_bug.cgi?id=15821
>>> https://github.com/fangism/llvm/commit/d27de53554abf4443ad386ea451991e4ef32f9ae
>>>
>>> Some PPC maintainers have already commented in the thread.
>>> Please review and commit on my behalf.
>>> Thanks.
>>>
>>> Fang
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

-- 
David Fang
http://www.csl.cornell.edu/~fang/




More information about the llvm-commits mailing list