[llvm] r180992 - Unbreaking the non-x86 build bots by protecting the AVX test code properly.

Kuperstein, Michael M michael.m.kuperstein at intel.com
Tue May 7 06:55:00 PDT 2013


Ok, great, I'll commit the fix.

-----Original Message-----
From: aaron.ballman at gmail.com [mailto:aaron.ballman at gmail.com] On Behalf Of Aaron Ballman
Sent: Tuesday, May 07, 2013 15:30
To: Kuperstein, Michael M
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r180992 - Unbreaking the non-x86 build bots by protecting the AVX test code properly.

On Tue, May 7, 2013 at 2:15 AM, Kuperstein, Michael M <michael.m.kuperstein at intel.com> wrote:
> Hi Aaron,
>
> This breaks AVX detection 64-bit platforms.
> I can add "|| defined(__x86_64__) || defined(_M_AMD64) || defined (_M_X64)" (this is what Hosts.cpp has), but I just want to make sure this is an omission and not a conscious decision first.

It was an omission -- I was thinking that because it was the X86SubTarget file, it only applied to x86 code and not x64.  Oops!
Good catch!

~Aaron
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.




More information about the llvm-commits mailing list