[PATCH] MC: Support larger COFF string tables

Daniel Dunbar daniel at zuster.org
Mon May 6 10:06:02 PDT 2013


I'm not sure how I feel about adding tests that are Python scripts that
generate test data. Such tests are going to be slow and impose another
requirement on understanding the test.

Is there any way this test could be written as a (gtest) unit test?

 - Daniel


On Sun, May 5, 2013 at 2:02 PM, Nico Rieck <nico.rieck at gmail.com> wrote:

>
>   I've split the base64 encoding into a separate commit now. But even the
> single-slash encoding would need a 1MB test file to test this change.
>
>   When running locally, making python available in PATH can be easily done
> by picking the current interpreter path in lit.cfg.
>   Is there any chance to skip this test otherwise?
>
>   Adding ddunbar as suggested.
>
> http://llvm-reviews.chandlerc.com/D667
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130506/d774f164/attachment.html>


More information about the llvm-commits mailing list