[llvm] r181050 - [PowerPC] Add assembler parser

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Mon May 6 04:18:57 PDT 2013


Evgeniy Stepanov <eugeni.stepanov at gmail.com> wrote on 06.05.2013 11:52:23:

> > +bool PPCAsmParser::
> > +MatchRegisterName(const AsmToken &Tok, unsigned &RegNo, int64_t
&IntVal) {
> > +  if (Tok.is(AsmToken::Identifier)) {
> > +    StringRef Name = Tok.getString().lower();
> > +
>
> this code is assigning an std::string temporary to StringRef. Ouch.

Oops.  Thanks for pointing this out!

I've checked in a fix as revision 181192.

Bye,
Ulrich




More information about the llvm-commits mailing list