Bug fix in Tblgen
Malul, Elior
elior.malul at intel.com
Fri May 3 00:00:30 PDT 2013
Hi, attached is the revised patch.
Any comments and reviews will be highly appreciated.
Description: Bugfix for tblgen foreach
Tests done: make, make check, as well as new tests (see attached patch).
Thx, Elior
-----Original Message-----
From: Jakob Stoklund Olesen [mailto:stoklund at 2pi.dk]
Sent: Monday, April 15, 2013 23:01
To: Malul, Elior
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: Bug fix in Tblgen
On Apr 14, 2013, at 3:16 AM, "Malul, Elior" <elior.malul at intel.com> wrote:
> Hi Jacob, attached is the new patch, in which the value propagation is done without adding it iterator artificially to the record.
> Will appreciate any reviews and comments.
Hi Elior,
Thanks for fixing this.
Please fix spelling, grammar, punctuation, whitespace, and all that stuff before sending patches. There's no need to spend time on that in code reviews.
Thanks,
/jakob
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iter_tblgen.patch
Type: application/octet-stream
Size: 8184 bytes
Desc: iter_tblgen.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130503/ff2cda87/attachment.obj>
More information about the llvm-commits
mailing list