[PATCH] [PowerPC, Darwin] fix for PR15821

Bill Schmidt wschmidt at linux.vnet.ibm.com
Thu May 2 20:35:31 PDT 2013



On Thu, 2013-05-02 at 22:56 -0400, David Fang wrote:
> Hi Bill,
> 
> >> For powerpc-darwin8, I have:
> >> .machine ppc7400
> >>
> >> For powerpc64-darwin8, I have:
> >> .machine ppc64
> >>
> >
> > Hm.  Using -mcpu=g4 (PowerPC 7400) gives me the code generation expected
> > by your DARWIN32 checks, so that's progress.  However, I can't get the
> > proper 64-bit code gen yet.  Using either -mcpu=ppc64 or -mcpu=g5 gives
> > me the attached assembly results, using current trunk to build llc.  Any
> > ideas why I see the differences?
> 
> What svn/git version of llvm/clang are you using?
> I'm on the powerpc-darwin8 branch, which last merged from trunk at 
> r180675.  There shouldn't be anything on my branch that touches powerpc64 
> codegen.  Let me know if you're using a more recent trunk build, and I'll 
> re-merge to that revision.

I'm at r180965.  I rather doubt there have been codegen changes like
this since r180675, but it's worth checking.

Thanks,
Bill

> 
> Fang
> 
> 
> >> Fang
> >>
> >>> (If you're unsure, run llc from the command line and look for
> >>> the .machine directive in the generated assembly file.)
> >>>
> >>> Thanks,
> >>> Bill
> >>>
> >>>>
> >>>> Thanks,
> >>>> Bill
> >>>>
> >>>> On Wed, 2013-05-01 at 17:08 -0400, David Fang wrote:
> >>>>> Hi,
> >>>>>
> >>>>> Attached is a patch for PR 15821, which fixes PowerPC CodeGen on Darwin.
> >>>>> It re-applies the same patch from PR 14779, and adds a test for darwin8,
> >>>>> targeting ppc32 and ppc64.
> >>>>>
> >>>>> http://llvm.org/bugs/show_bug.cgi?id=15821
> >>>>> https://github.com/fangism/llvm/commit/d27de53554abf4443ad386ea451991e4ef32f9ae
> >>>>>
> >>>>> Some PPC maintainers have already commented in the thread.
> >>>>> Please review and commit on my behalf.
> >>>>> Thanks.
> >>>>>
> >>>>> Fang
> >>>>>
> >>>>> _______________________________________________
> >>>>> llvm-commits mailing list
> >>>>> llvm-commits at cs.uiuc.edu
> >>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>>
> >>
> >
> 




More information about the llvm-commits mailing list