[PATCH] Rename Wrap.h to CBindingWrapping.h, and put wrap/unwrap definitions into respective C++ headers

[Eric Christopher]

On vacation at the moment so reviews are a little slow.

This looks good, mind putting a comment above every macro invocation
with "C Bindings blah". I'll leave the exact text up to you. :)

Thanks!

-eric

On Wed, May 1, 2013 at 6:17 PM, Filip Pizlo <fpizlo at apple.com> wrote:
> Ping!
>
> -Filip
>
>
>
>
> On Apr 30, 2013, at 2:12 PM, Filip Pizlo <fpizlo at apple.com> wrote:
>
> This patch breaks up Wrap.h so that it does not have to include all of the
> things, and renames it to CBindingWrapping.h.  I also moved
> CBindingWrapping.h into Support/; it seemed to me that this would be a
> better home for this header, though admittedly I don't actually know what
> the conventions are for this.
>
> This new file just contains the macros for defining different wrap/unwrap
> methods.
>
> The calls to those macros, as well as any custom wrap/unwrap definitions
> (like for array of Values for example), are put into corresponding C++
> headers.
>
> Doing this required some #include surgery, since some .cpp files relied on
> the fact that including Wrap.h implicitly caused the inclusion of a bunch of
> other things.
>
> This also now means that the C++ headers will include their corresponding C
> API headers; for example Value.h must include llvm-c/Core.h.  I think this
> is harmless, since the C API headers contain just external function
> declarations and some C types, so I don't believe there should be any nasty
> dependency issues here.
>
> -Filip
>
> <wrapping.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>