[PATCH] ARM build attributes support

[Amara Emerson]

Thanks for taking a look at this Rafael.

The ARMGenericBuildAttrInfo is just there for convenience, partly because attributes do not necessarily have integer types, but can be strings as well. I thought accessing the attributes symbolically would be a bit cleaner as well, but I don't have a strong preference for this method.

Yes, ARMBuildAttrs.h should be removed, I forgot to include that in the diff when I updated the old patch.

Cheers,
Amara

-----Original Message-----
From: Rafael Espíndola [mailto:rafael.espindola at gmail.com] 
Sent: 30 April 2013 15:21
To: Amara Emerson
Cc: llvm-commits
Subject: Re: [PATCH] ARM build attributes support

The only thing about this patch that looks odd is
ARMGenericBuildAttrInfo. Why do you have a class with every valid tag
as a member? Can't you return a list of (tag, value) pairs?

Is ARMBuildAttrs.h now redundant? Can it be removed?

Cheers,
Rafael