[PATCH] Rename Wrap.h to CBindingWrapping.h, and put wrap/unwrap definitions into respective C++ headers

Filip Pizlo fpizlo at apple.com
Tue Apr 30 14:12:14 PDT 2013


This patch breaks up Wrap.h so that it does not have to include all of the things, and renames it to CBindingWrapping.h.  I also moved CBindingWrapping.h into Support/; it seemed to me that this would be a better home for this header, though admittedly I don't actually know what the conventions are for this.

This new file just contains the macros for defining different wrap/unwrap methods.

The calls to those macros, as well as any custom wrap/unwrap definitions (like for array of Values for example), are put into corresponding C++ headers.

Doing this required some #include surgery, since some .cpp files relied on the fact that including Wrap.h implicitly caused the inclusion of a bunch of other things.

This also now means that the C++ headers will include their corresponding C API headers; for example Value.h must include llvm-c/Core.h.  I think this is harmless, since the C API headers contain just external function declarations and some C types, so I don't believe there should be any nasty dependency issues here.

-Filip

-------------- next part --------------
A non-text attachment was scrubbed...
Name: wrapping.patch
Type: application/octet-stream
Size: 27747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130430/067953ae/attachment.obj>


More information about the llvm-commits mailing list