[llvm] r180140 - Make sure the instruction right after an inlined function has a

[Eric Christopher]

On Mon, Apr 29, 2013 at 11:35 PM, Adrian Prantl <aprantl at apple.com> wrote:
>> On Apr 26, 2013, at 4:13 PM, Eric Christopher <echristo at gmail.com> wrote:
>>> Think you could investigate that last branch without debug info when
>>> you get a chance? Pretty sure it's not an issue, but want to be
>>> positive.
>
> Hi Eric!
>
> Investigated it and produced the attached patch.
> We will now attach debug locations to for branch instructions created during inlining, even the inlined function has multiple returns. (Which is the case the previous patch missed). There is no *right* debug location for the branch to the normal dest (because of the multiple returns), but I assume that having no debug location would be even worse, because we want that branch instruction counted toward the inlined function. That’s why I reused the debug location of the last return instruction for it.
>

Hi Adrian,

Thanks!

One nit:

"We need to set it the debug location to *somewhere* inside the"

Grammar :)

-eric