[llvm] r180744 - Duplicate a testcase.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Apr 29 18:40:01 PDT 2013


On 29 April 2013 18:45, Bill Wendling <isanbard at gmail.com> wrote:
> Rafael,
>
> Is this okay? Should I add more?

Less:

* Please delete the clang side test part that checks assembly. The
entire point is that there is no duplication. The clang test checks
what IL is produced. The llvm test checks what assembly is produced.
* Is this (llvm side) test x86 specific? You only CHECK the section
and a function pointer. Don't you guys use the same ABI for ARM?
* Since you are only checking that a section with a pointer is
construct, you should be able to simplify this test *a lot*. For
example, it looks like the content of __tls_init is irrelevant. You
can make it an empty function and still test that it is listed.

Cheers,
Rafael



More information about the llvm-commits mailing list