[llvm] r180750 - Revert the command line option patch. However, keep the part that makes this pass on Windows. I.e., we don't emit the target dependent attributes in a comment before the function.

[Chris Lattner]

On Apr 29, 2013, at 5:14 PM, Bill Wendling <isanbard at gmail.com> wrote:
> On Apr 29, 2013, at 5:13 PM, Chris Lattner <clattner at apple.com> wrote:
> 
>> Thanks Bill, shouldn't this also revert this part?
>> 
>>> /// \brief Return the attributes at the index as a string.
>>> -  std::string getAsString(unsigned Index, bool InAttrGrp = false) const;
>>> +  std::string getAsString(unsigned Index, bool TargetIndependent = true,
>>> +                          bool InAttrGrp = false) const;
>>> 
>>> typedef ArrayRef<Attribute>::iterator iterator;
>> 
>> Why is this needed on windows?
>> 
> There is a strange bug on Windows where it doesn't allow me to iterate through the attributes in the way I want. I can try to think up a different way to do it, though…

What is the bug?  We want consistent behavior on all hosts.  From your description it isn't clear if this is a host or target issue.

-Chris