[llvm] r180716 - Propagate relocation info to resolveRelocation.

[Kaylor, Andrew]

No, I just like things to be explicit.

I'm not aware of anything that derives from RuntimeDyldELF at the moment, though it might make sense to refactor it to divide the various architectures into subclasses.  I don't think there's been much thought given to dividing private and protected in that class.  Making just that one function private gives the impression that the other stuff really should be protected, which isn't necessarily true.

-Andy

-----Original Message-----
From: Rafael Espíndola [mailto:rafael.espindola at gmail.com] 
Sent: Monday, April 29, 2013 11:52 AM
To: Kaylor, Andrew
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r180716 - Propagate relocation info to resolveRelocation.

On 29 April 2013 14:36, Kaylor, Andrew <andrew.kaylor at intel.com> wrote:
> Did you mean to move resolveRelocation outside the 'protected' area in RuntimeDyldELF?

It is now private. It was intentional, yes. Every outside user is using the virtual interface, so this is just an internal implementation detail. Do you have code that expects to be able to call it directly?

Cheers,
Rafael