[PowerPC CodeGen] patch for bug 15763

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Apr 26 15:35:20 PDT 2013


On 22 April 2013 16:57, David Fang <fang at csl.cornell.edu> wrote:
> Hi all,
>
> Attached is a patch that fixes PIC codegen for PPC on darwin, by privatizing
> all function stubs and lazy pointer symbols in emitted assembly.
>
> http://llvm.org/bugs/show_bug.cgi?id=15763
>
> Could PPC maintainers kindly review/apply?  Thanks.

getPrivateGlobalPrefix can take a twine, so it is probably better to do

const char* Prefix;
if (...)
  Prefix =  = AP.MAI->getPrivateGlobalPrefix();
else
  Prefix = "";
MCSymbol Sym = Ctx.GetOrCreateSymbol(Twine(Prefix) + Twine(Name));

Btw, is there a case where the prefix was already added? I.e., is
Name.startswith(plp) ever true? It would be nice if the prefix could
be added in one central location.

Cheers,
Rafael



More information about the llvm-commits mailing list