[PATCH] New SystemZ backend: LLVM code changes

Richard Sandiford rsandifo at linux.vnet.ibm.com
Fri Apr 26 07:02:44 PDT 2013


Rafael EspĂ­ndola <rafael.espindola at gmail.com> writes:
>> Ah, OK, thanks for the explanation.  How does this version look?
>
> Much better, but you can cleanup the .s -> .o tests a bit, no? Now
> that it is a .s test you probably don't need all the branching and
> function calling. In fact,you probably just need the .cfi_ directives,
> no? All that will change in the .eh_frame section are the addresses.

We need more than just .cfi_* directives if we want to keep testing the
DW_CFA_advance_loc bits.  I suppose I could change the test so that it
has a zero-sized function with CFI info like:

#   DW_CFA_offset: r13 at cfa-56
#   DW_CFA_offset: r14 at cfa-48
#   DW_CFA_offset: r15 at cfa-40
#   DW_CFA_def_cfa_offset: 320

and no DW_CFA_advance_locs, but in practice no function is going
to look like that.  (The allocation and storing are done by
separate instructions.)

This version removes the calls and the .gcc_except_table contents though.

Thanks,
Richard

-------------- next part --------------
A non-text attachment was scrubbed...
Name: debug-info-tests.diff
Type: text/x-patch
Size: 12068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130426/f33fbab7/attachment.bin>


More information about the llvm-commits mailing list