[PATCH] New SystemZ backend: LLVM code changes

[Richard Sandiford]

Rafael Espíndola <rafael.espindola at gmail.com> writes:
>> Thanks for the pointer.  How does this look?  In case anyone's
>> wondering, I didn't add an equivalent of DebugInfo/AArch64/cfi-frame.ll
>> because .cfi_* directives are already tested in the CodeGen/SystemZ/frame-*.ll
>> tests.
>
> Why -filetype=obj test? Please split these in two:
>
> * A .ll to .s test that checks that the expected .cfi_* directives are produced
> * A .s to .o test that checks that .cfi_ directives are correctly assembled.

Hmm, I was just trying to mimic the AArch64 tests, like Eric said. :-)
Do you mean that there's something wrong with the way those work,
or with the way I adapted them?

In case it helps, the CodeGen/SystemZ/frame-*.ll tests that I mentioned
are attached (all of them, including some that aren't CFI-related).
I think it makes sense to test the .cfi_* .s output alongside the
prologue and epilogue tests.

Richard

-------------- next part --------------
A non-text attachment was scrubbed...
Name: frame-tests.diff
Type: text/x-patch
Size: 124339 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130426/407b422e/attachment.bin>