[PATCH] Inserting directives directly after inline asm blocks

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Apr 25 13:04:23 PDT 2013


On 25 April 2013 16:00, Jack Carter <Jack.Carter at imgtec.com> wrote:
> I guess I am missing something here.
>
> I do not expect the code generator to ever to support .set reorder. It is due to ancient compilers not handling delay slots in Mips and leaving that to the assembler. The assembler handles the state of reorder/noreorder on its own just as it will handle pushed and popped states in the future. This emission of the set reorder/noreorder is just to feed the assembler what it expects.
>
> I don't see the need to create the new methods, but I do want to know why I am wrong ;-)

MC is not a code generator, it is an assembler. If user inline
assembly requires ".set reorder", you will need to implement this in
MC. It is better to get an error now than to silently drop it by
checking hasRawTextSupport.


> Jack

Cheers,
Rafael




More information about the llvm-commits mailing list