[PATCH] x86_64: Fix section relocation for SECTIONREL32 with immediate offset
Rafael Espíndola
rafael.espindola at gmail.com
Thu Apr 25 12:27:38 PDT 2013
r180568, thanks!
On 25 April 2013 12:09, Kai Nacke <kai at redstar.de> wrote:
> Please, could you commit the patch for me? I still don't have commit
> access...
>
> Regards
> Kai
>
>
> On 25.04.2013 15:54, Rafael Espíndola wrote:
>>
>> LGTM!
>>
>> On 25 April 2013 02:14, Kai Nacke <kai at redstar.de> wrote:
>>>
>>> Hi Rafael,
>>>
>>> it isn't hard. llvm-mc understands the @SECREL32 variant with my new
>>> patch.
>>> I also translated the test case to assembly.
>>>
>>> Sorry that I did not check this opportunity before sending my patch.
>>>
>>> Regards
>>> Kai
>>>
>>>
>>> On 25.04.2013 04:50, Rafael Espíndola wrote:
>>>>>
>>>>> The attached test case is a .ll file because llvm-mc does not support
>>>>> @SECTIONREL32.
>>>>
>>>> Would that be too hard to add? It would be much better if we could
>>>> test this with assembly.
>>>>
>>>> Assembling
>>>>
>>>> movq values at SECREL32(%rax), %rcx
>>>> movq values at SECREL32+8(%rax), %rax
>>>>
>>>> with gas and then running llvm-reoadobj -r I got
>>>>
>>>> 0x3 IMAGE_REL_AMD64_SECREL values
>>>> 0xA IMAGE_REL_AMD64_SECREL values
>>>>
>>>> Cheers,
>>>> Rafael
>>>>
>
More information about the llvm-commits
mailing list