[PATCH] Inserting directives directly after inline asm blocks

Jack Carter Jack.Carter at imgtec.com
Thu Apr 25 08:35:14 PDT 2013


Rafael,

Thanks for looking at this.

Yes, it is on our road map for llvm-mc to support .set reorder and to have that as the defacto default for historical purposes.

I don't understand the other suggestions though. I thought I generated this codegen operation like the the others. How is this different? Is there a precedent? Some example that I can model? 

Jack
________________________________________
From: Rafael EspĂ­ndola [rafael.espindola at gmail.com]
Sent: Wednesday, April 24, 2013 7:39 PM
To: Jack Carter
Cc: Richard Sandiford; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Inserting directives directly after inline asm blocks

On 24 April 2013 21:18, Jack Carter <Jack.Carter at imgtec.com> wrote:
> I am resubmitting the revised patch based on Richard's suggestions.
>
> May I check it in ;-)

One more question:

Is the assembler *required* or just *allowed* to do the reordering? If
it is required, you will need to implement this in MC at some point,
so using hasRawTextSupport is probably not a good idea. Please add a
streamer call for it. It is OK to just produce an error on the object
streamer for now when trying to set the mode to reorder.

Cheers,
Rafael





More information about the llvm-commits mailing list