[PATCH] Bug 9761: EmitEndOfAsmFile is not the final emission point.

Matt Arsenault Matthew.Arsenault at amd.com
Wed Apr 24 11:20:21 PDT 2013


  This breaks 6 tests. 2 of them are Darwin x86 (2010-12-02-MC-Set.ll and personality.ll) because of the placement of .subsections_via_symbols

  The comment emitting it in X86AsmPrinter says
      // Funny Darwin hack: This flag tells the linker that no global symbols
      // contain code that falls through to other global symbols (e.g. the obvious
      // implementation of multiple entry points).

  So does the placement of this not actually matter? Is it OK to just move the expected location in the tests?

  The other 4 are ARM and Mips object tests, which I don't understand yet.

http://llvm-reviews.chandlerc.com/D633



More information about the llvm-commits mailing list