[PATCH] Fix for CodeGenPrepare wrongly updating the map of sunk addresses

Andrea_DiBiagio at sn.scee.net Andrea_DiBiagio at sn.scee.net
Wed Apr 24 04:56:00 PDT 2013


Hi Anton!

Anton Korobeynikov <anton at korobeynikov.info> wrote on 24/04/2013 12:13:28:

> Hi Andrea,
> 
> Are you sure the tests will pass on *every* x86 target? Regardless of
> the platform?

I see what you mean..
My test wouldn't work for example on a generic x86  or - in general - if I 
disable sse.
When I originally tested my fix I used the following RUN directive:

; RUN: llc < %s -mtriple=x86_64-pc-linux | Filecheck %s

Then, I wrongly thought that I could have extended the test to all the x86 
targets.
On a generic x86 (with no sse support) I would always get instead the 
sequence:

    flds    12(%eax)
    fstps  60(%eax)


Sorry about that.
Do you think that changing the RUN directive to match the triple would be 
reasonable?
Specifying triple x86_64-pc-linux able should be enough I think to get the 
expected sequence of movss instructions.

Thanks,
-- Andrea Di Biagio


**********************************************************************
This email and any files transmitted with it are confidential and intended 
solely for the use of the individual or entity to whom they are addressed. 
If you have received this email in error please notify postmaster at scee.net
This footnote also confirms that this email message has been checked for 
all known viruses.
Sony Computer Entertainment Europe Limited
Registered Office: 10 Great Marlborough Street, London W1F 7LP, United 
Kingdom
Registered in England: 3277793
**********************************************************************

P Please consider the environment before printing this e-mail



More information about the llvm-commits mailing list