llvm-c patch for atomicrmw & dibuilder

[Eric Christopher]

Hi Carlo,

+#include "llvm/DebugInfo.h"
+#include "llvm/DIBuilder.h"

I'd like to avoid including c++ files in the c headers at all.

I'm also not sure how much I really want to open the API as much as
this. The DIBuilder interface doesn't change much, but it's very much
based on the MDNodes that we emit. Since the C API is very static I'd
like to avoid the lock-in that this sets the API up for.

Do you think we could distill down the API a bit more and make it more
flexible? Things like createFoo will create a minimum Foo and then
have routines to add specific details?

Thoughts?

-eric


On Tue, Apr 23, 2013 at 3:36 PM, Carlo Kok <ck at remobjects.com> wrote:
> Op 23-4-2013 01:14, Eric Christopher schreef:
>>
>> OK, I've committed my patch. You'll need to rebase and make some
>>
>> changes to your current set of patches so that we keep the C++ out of
>> the C headers.
>>
>
> Attached is an updated DIBuilder; I didn't put the c++ stuff in "Wrap.h" as
> this was the only file using them, let me know if this is ok, I'll commit
> then.
>
> --
> Carlo Kok
>