[llvm] r179996 - Revert "Revert "PR14606: debug info imported_module support""

David Blaikie dblaikie at gmail.com
Mon Apr 22 20:16:28 PDT 2013


On Mon, Apr 22, 2013 at 12:38 AM, Eric Christopher <echristo at gmail.com> wrote:
> Should probably mention what the fix was?

Oh, sure. The diff of two-cus-from-same-file.ll shows it fairly
clearly, which is to say it's the same change as all the other test
files. It just wasn't failing on X86 for some reason - and I don't
really know why that is. (presumably a different codepath that didn't
assert on broken DICompileUnits)

(& then the other change I made was to the GDB 7.5 test suite in
clang-tests-external, to un-XFAIL the few cases this fixed)

>> Modified: llvm/trunk/test/DebugInfo/two-cus-from-same-file.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/two-cus-from-same-file.ll?rev=179996&r1=179995&r2=179996&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/DebugInfo/two-cus-from-same-file.ll (original)
>> +++ llvm/trunk/test/DebugInfo/two-cus-from-same-file.ll Mon Apr 22 01:12:31 2013
>> @@ -34,14 +34,14 @@ declare void @llvm.dbg.value(metadata, i
>>
>>  !llvm.dbg.cu = !{!0, !9}
>>
>> -!0 = metadata !{i32 786449, metadata !32, i32 12, metadata !"clang version 3.2 (trunk 156513)", i1 true, metadata !"", i32 0, metadata !1, metadata !1, metadata !3, metadata !1, metadata !""} ; [ DW_TAG_compile_unit ]
>> +!0 = metadata !{i32 786449, metadata !32, i32 12, metadata !"clang version 3.2 (trunk 156513)", i1 true, metadata !"", i32 0, metadata !1, metadata !1, metadata !3, metadata !1, metadata !1, metadata !""} ; [ DW_TAG_compile_unit ]
>>  !1 = metadata !{i32 0}
>>  !3 = metadata !{metadata !5}
>>  !5 = metadata !{i32 786478, metadata !6, metadata !"foo", metadata !"foo", metadata !"", metadata !6, i32 5, metadata !7, i1 false, i1 true, i32 0, i32 0, null, i32 256, i1 true, void ()* @foo, null, null, metadata !1, i32 5} ; [ DW_TAG_subprogram ]
>>  !6 = metadata !{i32 786473, metadata !32} ; [ DW_TAG_file_type ]
>>  !7 = metadata !{i32 786453, i32 0, metadata !"", i32 0, i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !8, i32 0, i32 0} ; [ DW_TAG_subroutine_type ]
>>  !8 = metadata !{null}
>> -!9 = metadata !{i32 786449, metadata !32, i32 12, metadata !"clang version 3.2 (trunk 156513)", i1 true, metadata !"", i32 0, metadata !1, metadata !1, metadata !10, metadata !1, metadata !""} ; [ DW_TAG_compile_unit ]
>> +!9 = metadata !{i32 786449, metadata !32, i32 12, metadata !"clang version 3.2 (trunk 156513)", i1 true, metadata !"", i32 0, metadata !1, metadata !1, metadata !10, metadata !1, metadata !1, metadata !""} ; [ DW_TAG_compile_unit ]
>>  !10 = metadata !{metadata !12}
>>  !12 = metadata !{i32 786478, metadata !6, metadata !"main", metadata !"main", metadata !"", metadata !6, i32 11, metadata !13, i1 false, i1 true, i32 0, i32 0, null, i32 256, i1 true, i32 (i32, i8**)* @main, null, null, metadata !19, i32 11} ; [ DW_TAG_subprogram ]
>>  !13 = metadata !{i32 786453, i32 0, metadata !"", i32 0, i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !14, i32 0, i32 0} ; [ DW_TAG_subroutine_type ]




More information about the llvm-commits mailing list