[PATCH][llvm-c] Expose MC JIT

Filip Pizlo fpizlo at apple.com
Mon Apr 22 17:37:24 PDT 2013


Actually, it looks like the MCJIT tests claim Darwin as an unsupported platform.

Is this accurate?  If I hack the MCJITTestBase to claim to support Darwin, then the tests do indeed crash.

Also, it is generally true, as far as I can tell, that the C API doesn't have tests.

Let me know how you want me to proceed: should I first fix MCJIT enough to make it supported on Darwin, and write the first-ever C API unit test, as a prerequisite to exposing enough MCJIT functionality in LLVM that I can actually start using it in WebKit?  I would rather this get landed - that will at least unblock me a bit, and then I'd be happy to help in ruggedizing the MCJIT.

-Filip


On Apr 22, 2013, at 4:50 PM, Filip Pizlo <fpizlo at apple.com> wrote:

> 
> 
> On Apr 22, 2013, at 4:43 PM, "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:
> 
>> Looks great!
>>  
>> Any chance you have tests for this?
> 
> Heh, good question. I tested it by running WebKit tests, but I can do better. Anything I should be mindful of when writing unit tests for the MCJIT?  And in particular the C API?  I couldn't immediately find we're C API tests lived. 
> 
>>  
>> -Andy
>>  
>> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Filip Pizlo
>> Sent: Monday, April 22, 2013 2:09 PM
>> To: llvm-commits at cs.uiuc.edu
>> Subject: Re: [PATCH][llvm-c] Expose MC JIT
>>  
>> Here it is.  The C API no longer exposes finalizeObject() in any way, and makes sure to call it prior to doing anything that the user would expect to have already done permissions/invalidation.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130422/4f01892d/attachment.html>


More information about the llvm-commits mailing list