[llvm] r180010 - Add .ll as a valid test suffix for Object, this allows .ll -> object

Eric Christopher echristo at gmail.com
Mon Apr 22 15:56:16 PDT 2013


On Mon, Apr 22, 2013 at 11:52 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
> On Apr 22, 2013 8:48 PM, "Eric Christopher" <echristo at gmail.com> wrote:
>>
>> Author: echristo
>> Date: Mon Apr 22 05:45:06 2013
>> New Revision: 180010
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=180010&view=rev
>> Log:
>> Add .ll as a valid test suffix for Object, this allows .ll -> object
>> and then dumping as tests.
>
> Not sure how I feel about this (but I think we've had this sort of
> discussion before) - isolated testing (so the test only fails or passes for
> lib object reasons, not because we did something different with the given
> .ll) versus relevant testing (testing the kinds of object files we actually
> generate).
>

We have :)

And yeah, I think we came down to "hey, we've got these great points".
Only reason I really did here was to avoid having 2 object files
checked in for 2 tests.

-eric



More information about the llvm-commits mailing list