[llvm] r179926 - Move PPC getSwappedPredicate for reuse

Hal Finkel hfinkel at anl.gov
Fri Apr 19 22:16:26 PDT 2013


Author: hfinkel
Date: Sat Apr 20 00:16:26 2013
New Revision: 179926

URL: http://llvm.org/viewvc/llvm-project?rev=179926&view=rev
Log:
Move PPC getSwappedPredicate for reuse

The getSwappedPredicate function can be used in other places (such as in
improvements to the PPCCTRLoops pass). Instead of trapping it as a static
function in PPCInstrInfo, move it into PPCPredicates with other
predicate-related things.

No functionality change intended.

Modified:
    llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp
    llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.h
    llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp

Modified: llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp?rev=179926&r1=179925&r2=179926&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp Sat Apr 20 00:16:26 2013
@@ -29,3 +29,18 @@ PPC::Predicate PPC::InvertPredicate(PPC:
   }
   llvm_unreachable("Unknown PPC branch opcode!");
 }
+
+PPC::Predicate PPC::getSwappedPredicate(PPC::Predicate Opcode) {
+  switch (Opcode) {
+  case PPC::PRED_EQ: return PPC::PRED_EQ;
+  case PPC::PRED_NE: return PPC::PRED_NE;
+  case PPC::PRED_LT: return PPC::PRED_GT;
+  case PPC::PRED_GE: return PPC::PRED_LE;
+  case PPC::PRED_GT: return PPC::PRED_LT;
+  case PPC::PRED_LE: return PPC::PRED_GE;
+  case PPC::PRED_NU: return PPC::PRED_NU;
+  case PPC::PRED_UN: return PPC::PRED_UN;
+  }
+  llvm_unreachable("Unknown PPC branch opcode!");
+}
+

Modified: llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.h?rev=179926&r1=179925&r2=179926&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.h (original)
+++ llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.h Sat Apr 20 00:16:26 2013
@@ -37,6 +37,10 @@ namespace PPC {
   
   /// Invert the specified predicate.  != -> ==, < -> >=.
   Predicate InvertPredicate(Predicate Opcode);
+
+  /// Assume the condition register is set by MI(a,b), return the predicate if
+  /// we modify the instructions such that condition register is set by MI(b,a).
+  Predicate getSwappedPredicate(Predicate Opcode);
 }
 }
 

Modified: llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp?rev=179926&r1=179925&r2=179926&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp Sat Apr 20 00:16:26 2013
@@ -1087,22 +1087,6 @@ bool PPCInstrInfo::analyzeCompare(const
   }
 }
 
-/// Assume the flags are set by MI(a,b), return the condition code if we modify
-/// the instructions such that flags are set by MI(b,a).
-PPC::Predicate static getSwappedPredicate(PPC::Predicate Opcode) {
-  switch (Opcode) {
-  case PPC::PRED_EQ: return PPC::PRED_EQ;
-  case PPC::PRED_NE: return PPC::PRED_NE;
-  case PPC::PRED_LT: return PPC::PRED_GT;
-  case PPC::PRED_GE: return PPC::PRED_LE;
-  case PPC::PRED_GT: return PPC::PRED_LT;
-  case PPC::PRED_LE: return PPC::PRED_GE;
-  case PPC::PRED_NU: return PPC::PRED_NU;
-  case PPC::PRED_UN: return PPC::PRED_UN;
-  }
-  llvm_unreachable("Unknown PPC branch opcode!");
-}
- 
 bool PPCInstrInfo::optimizeCompareInstr(MachineInstr *CmpInstr,
                                         unsigned SrcReg, unsigned SrcReg2,
                                         int Mask, int Value,
@@ -1320,7 +1304,7 @@ bool PPCInstrInfo::optimizeCompareInstr(
                 Pred == PPC::PRED_EQ || Pred == PPC::PRED_NE) &&
                "Invalid predicate for equality-only optimization");
         PredsToUpdate.push_back(std::make_pair(&((*I).getOperand(0)),
-                                getSwappedPredicate(Pred)));
+                                PPC::getSwappedPredicate(Pred)));
       } else if (UseMI->getOpcode() == PPC::ISEL ||
                  UseMI->getOpcode() == PPC::ISEL8) {
         unsigned NewSubReg = UseMI->getOperand(3).getSubReg();





More information about the llvm-commits mailing list