[llvm] r179923 - These can be void.

Rafael Espindola rafael.espindola at gmail.com
Fri Apr 19 20:33:09 PDT 2013


Author: rafael
Date: Fri Apr 19 22:33:09 2013
New Revision: 179923

URL: http://llvm.org/viewvc/llvm-project?rev=179923&view=rev
Log:
These can be void.

Modified:
    llvm/trunk/tools/obj2yaml/coff2yaml.cpp

Modified: llvm/trunk/tools/obj2yaml/coff2yaml.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/obj2yaml/coff2yaml.cpp?rev=179923&r1=179922&r2=179923&view=diff
==============================================================================
--- llvm/trunk/tools/obj2yaml/coff2yaml.cpp (original)
+++ llvm/trunk/tools/obj2yaml/coff2yaml.cpp Fri Apr 19 22:33:09 2013
@@ -233,8 +233,8 @@ const char *nameLookup(const pod_pair<T,
   return NotFound;
 }
 
-static raw_ostream &yamlCOFFHeader(const object::coff_file_header *Header,
-                                   raw_ostream &Out) {
+static void yamlCOFFHeader(const object::coff_file_header *Header,
+                           raw_ostream &Out) {
   COFF::header H;
   H.Machine = Header->Machine;
   H.Characteristics = Header->Characteristics;
@@ -243,13 +243,12 @@ static raw_ostream &yamlCOFFHeader(const
   Out << "  Machine: ";
   Out << nameLookup(MachineTypePairs, Header->Machine, "# Unknown_MachineTypes")
       << " # (";
-  return objyaml::writeHexNumber(Out, Header->Machine) << ")\n\n";
+  objyaml::writeHexNumber(Out, Header->Machine) << ")\n\n";
 }
 
 
-static raw_ostream &yamlCOFFSections(object::COFFObjectFile &Obj,
-                                     std::size_t NumSections,
-                                     raw_ostream &Out) {
+static void yamlCOFFSections(object::COFFObjectFile &Obj,
+                             std::size_t NumSections, raw_ostream &Out) {
   error_code ec;
   Out << "sections:\n";
   for (object::section_iterator iter = Obj.begin_sections();
@@ -290,12 +289,10 @@ static raw_ostream &yamlCOFFSections(obj
       }
 
   }
-  return Out;
 }
 
-static raw_ostream& yamlCOFFSymbols(object::COFFObjectFile &Obj,
-                                    std::size_t NumSymbols,
-                                    raw_ostream &Out) {
+static void yamlCOFFSymbols(object::COFFObjectFile &Obj, std::size_t NumSymbols,
+                            raw_ostream &Out) {
   error_code ec;
   Out << "symbols:\n";
   for (object::symbol_iterator iter = Obj.begin_symbols();
@@ -339,8 +336,6 @@ static raw_ostream& yamlCOFFSymbols(obje
 
     Out << '\n';
   }
-
-  return Out;
 }
 
 





More information about the llvm-commits mailing list