[llvm] r179891 - Remove COFFYAML::Relocation.

Rafael Espindola rafael.espindola at gmail.com
Fri Apr 19 14:28:07 PDT 2013


Author: rafael
Date: Fri Apr 19 16:28:07 2013
New Revision: 179891

URL: http://llvm.org/viewvc/llvm-project?rev=179891&view=rev
Log:
Remove COFFYAML::Relocation.

Use MappingNormalization to read a COFF::relocation directly.

No functionality change.

Modified:
    llvm/trunk/tools/yaml2obj/yaml2obj.cpp

Modified: llvm/trunk/tools/yaml2obj/yaml2obj.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2obj.cpp?rev=179891&r1=179890&r2=179891&view=diff
==============================================================================
--- llvm/trunk/tools/yaml2obj/yaml2obj.cpp (original)
+++ llvm/trunk/tools/yaml2obj/yaml2obj.cpp Fri Apr 19 16:28:07 2013
@@ -114,16 +114,10 @@ static bool hexStringToByteArray(StringR
 // The structure of the yaml files is not an exact 1:1 match to COFF. In order
 // to use yaml::IO, we use these structures which are closer to the source.
 namespace COFFYAML {
-  struct Relocation {
-    uint32_t VirtualAddress;
-    uint32_t SymbolTableIndex;
-    COFF::RelocationTypeX86 Type;
-  };
-
   struct Section {
     COFF::SectionCharacteristics Characteristics;
     StringRef SectionData;
-    std::vector<Relocation> Relocations;
+    std::vector<COFF::relocation> Relocations;
     StringRef Name;
   };
 
@@ -407,7 +401,7 @@ void writeCOFF(COFFParser &CP, raw_ostre
   OS.write(&CP.StringTable[0], CP.StringTable.size());
 }
 
-LLVM_YAML_IS_SEQUENCE_VECTOR(COFFYAML::Relocation)
+LLVM_YAML_IS_SEQUENCE_VECTOR(COFF::relocation)
 LLVM_YAML_IS_SEQUENCE_VECTOR(COFFYAML::Section)
 LLVM_YAML_IS_SEQUENCE_VECTOR(COFFYAML::Symbol)
 
@@ -646,9 +640,23 @@ struct MappingTraits<COFFYAML::Header> {
 };
 
 template <>
-struct MappingTraits<COFFYAML::Relocation> {
-  static void mapping(IO &IO, COFFYAML::Relocation &Rel) {
-    IO.mapRequired("Type", Rel.Type);
+struct MappingTraits<COFF::relocation> {
+  struct NormalizedType {
+  public:
+    NormalizedType(IO &) : Type(COFF::RelocationTypeX86(0)) {
+    }
+    NormalizedType(IO &, uint16_t T) : Type(COFF::RelocationTypeX86(T)) {
+    }
+    uint16_t denormalize(IO &) {
+      return Type;
+    }
+
+    COFF::RelocationTypeX86 Type;
+  };
+  static void mapping(IO &IO, COFF::relocation &Rel) {
+    MappingNormalization<NormalizedType, uint16_t> foo(IO, Rel.Type);
+
+    IO.mapRequired("Type", foo->Type);
     IO.mapRequired("VirtualAddress", Rel.VirtualAddress);
     IO.mapRequired("SymbolTableIndex", Rel.SymbolTableIndex);
   }





More information about the llvm-commits mailing list