[PATCH] Fix treatment of ARM unallocated hint instructions

Quentin Colombet qcolombet at apple.com
Wed Apr 17 11:48:05 PDT 2013


Committed in r179707.
-Quentin

On Apr 17, 2013, at 10:13 AM, Mihail Popa <mihail.popa at gmail.com> wrote:

> Quentin,
> 
> Please commit this patch for me.
> 
> Thanks,
> Mihai
> 
> 
> On Wed, Apr 17, 2013 at 5:31 PM, Quentin Colombet <qcolombet at apple.com> wrote:
> LGTM.
> 
> -Quentin
> 
> On Apr 17, 2013, at 3:10 AM, Mihail Popa <mihail.popa at gmail.com> wrote:
> 
>> Hi.
>> 
>> I have amended the patch by removing white space trimming and replacing grep with FileCheck.
>> 
>> Regards,
>> Mihai
>> 
>> 
>> On Tue, Apr 16, 2013 at 7:47 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>> Oh yes, that’s true. I’ve forgotten about that!
>> 
>> -Quentin
>> 
>> On Apr 16, 2013, at 11:36 AM, Tim Northover <t.p.northover at gmail.com> wrote:
>> 
>>>> Maybe I’m missing something but you’ve defined a new isImm0_4 method but
>>>> you’re never using it.
>>> 
>>> That's automatically used by TableGen based on the Name member in the
>>> AsmOperandClass, isn't it?
>>> 
>>> Tim.
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
>> <LLVM-713.hints.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130417/5a82a250/attachment.html>


More information about the llvm-commits mailing list